Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support intellij 2024.2 #68

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Support intellij 2024.2 #68

wants to merge 11 commits into from

Conversation

HilaG
Copy link
Contributor

@HilaG HilaG commented Oct 27, 2024 •
edited
Loading

Description

Please describe your changes in detail.

  • Relevant Issues :

  • What Changed and Why? :

Types of changes

  • Type of change :
    • New feature
    • Bug fix
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

Checklist

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.27273% with 144 lines in your changes missing coverage. Please review.

Project coverage is 52.19%. Comparing base (a71c4b2) to head (0be2613).
Report is 58 commits behind head on master.

Files with missing lines Patch % Lines
...it/ddb/conf/DockDockBuildRunConfigurationEditor.kt 0.00% 33 Missing ⚠️
...m/intuit/ddb/conf/DockDockBuildRunConfiguration.kt 0.00% 26 Missing ⚠️
...opp/intellij/makefile/MakefileColorSettingsPage.kt 0.00% 24 Missing ⚠️
...kotlin/com/intuit/ddb/DockDockBuildConfigurable.kt 0.00% 12 Missing ⚠️
...opp/intellij/makefile/MakefileSyntaxHighlighter.kt 26.66% 0 Missing and 11 partials ⚠️
.../com/intuit/ddb/DockerfileFileChooserDescriptor.kt 0.00% 7 Missing ⚠️
...pp/intellij/makefile/MakefileFindUsagesProvider.kt 50.00% 5 Missing and 2 partials ⚠️
...pp/intellij/makefile/psi/MakefileElementFactory.kt 44.44% 5 Missing ⚠️
...t/ddb/conf/DockDockBuildRunConfigurationFactory.kt 0.00% 4 Missing ⚠️
...tellij/makefile/MakefileChooseByNameContributor.kt 0.00% 4 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #68      +/-   ##
============================================
+ Coverage     49.13%   52.19%   +3.05%     
============================================
  Files            86       86              
  Lines          2202     2029     -173     
  Branches        373      518     +145     
============================================
- Hits           1082     1059      -23     
+ Misses          828      716     -112     
+ Partials        292      254      -38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shaharkozi shaharkozi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HilaG @codecov-commenter @shaharkozi